Avoid creating a pass for main_transparent_pass_2d when unecessary#24850
Open
PJB3005 wants to merge 1 commit into
Open
Avoid creating a pass for main_transparent_pass_2d when unecessary#24850PJB3005 wants to merge 1 commit into
PJB3005 wants to merge 1 commit into
Conversation
mardzie
approved these changes
Jul 2, 2026
mardzie
left a comment
mardzie
left a comment
There was a problem hiding this comment.
The code looks good to me but I am not familiar with the broader context.
beicause
approved these changes
Jul 3, 2026
Member
There was a problem hiding this comment.
Makes sense.
We already skipped empty render pass for 3d
transparent 3d doesn't skip the webgl2 workaround though, but this is fine (#24851).
Author
Yeah I figured that'd be fine since we're not doing anything here. |
kfc35
added
A-Rendering
kfc35
added
the
D-Straightforward
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Objective
Solution
Testing
2d_shapesandtransparency_2dexamples and it looks fine.Showcase